Implement suggestion from digisaster #206

bouwew · 2025-02-16T12:56:32Z

As described on Discord: "het maakt net even het verschil tussen 100% CPU of 6% (op mijn raspberry)".

Collect Stick NodeInfo

coderabbitai · 2025-02-16T12:56:39Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-02-16T12:56:42Z

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.14%. Comparing base (91c9d1b) to head (0cd1703).

Files with missing lines	Patch %	Lines
plugwise_usb/nodes/circle.py	20.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##            async     #206      +/-   ##
==========================================
- Coverage   81.16%   81.14%   -0.02%     
==========================================
  Files          36       36              
  Lines        7364     7367       +3     
==========================================
+ Hits         5977     5978       +1     
- Misses       1387     1389       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bouwew

Should we increase this delay a bit more?

sonarqubecloud · 2025-02-16T19:16:48Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

bouwew · 2025-02-27T19:23:11Z

I was thinking, in the Integration (async) there are these lines: PARALLEL_UPDATES = 2.
I wonder what the result will be on a Pi when set to 1?

brefra · 2025-02-28T19:22:39Z

plugwise_usb/nodes/circle.py

            missing_addresses = sorted(missing_addresses, reverse=True)
            for address in missing_addresses:
                await self.energy_log_update(address)
+                await sleep(0.1)  # Test with a small delay


The sleep should not be necessary at all. Adding it masks the real issue at the submit queue.
Any "communication overload" should be handled properly at the submit queue so we are able to do all the energy requests in a single gather request.

bouwew · 2025-04-23T10:20:25Z

Closing this PR, @digisaster comfirms that the present async-code does not show the high utilization.

brefra added 30 commits August 23, 2024 19:24

Improve naming for send and receive tasks

761f3c0

Add send counter to request message representation

f645ccb

Unsubscribe to messages when error is assigned

b6364dd

Simplify representation of CircleEnergyLogsRequest

d911aa8

Add address to representation for CirclePlusScanRequest

e1238f8

Expand representation of CirclePlusScanResponse

faba223

Expand representation of StickInitResponse

f39123e

Add retries to representation of Response messages

036e337

Return outside of try block

b30d040

Remove unused function

5edb24c

Keep track and log result of subscribers

bedb180

Check for connection before sending requests

b7d16fc

Use stick response type to validate successful sending request

18211f8

Raise when seq_id is changed

64f8504

Reset seq_id at timeout

de373d0

Remove object_id

191d6d6

Simplify stick response

e3bfd80

Rewrite response message subscription

896a629

Rewrite node response handling

d96f780

Fix protocol support for clock set request

6850a74

Correct typing

00a7430

Only save cache when energy record is updated

2451efb

Only request node info when outdated

5bad9d1

Remove redundant check

d24a45e

Cleanup and correct doc strings

9078b14

Improve log messages

70727f8

Improve NodeTimout error message

44798c2

Add extra info message

dfa0246

Remove obsolete else

1623b19

Sync pyproject.toml to main branch

8f1cb29

bouwew and others added 17 commits February 13, 2025 10:47

Remove, not needed

1a78559

Collect Stick data during initialization

4397479

Adapt asserts

b1314a0

Translate to short hardware-version

c703f2e

Adapt and clean-up test-asserts

02c2724

Clean up debug-logging

008b59a

Clean-up

d0de725

Pylint fix

7de9d46

Bump to a30

d3a494a

Add Stick-name property

ea09df7

Add related test-assert

a2d395a

Bump to a31

ef0df7c

Simplify property-names, improve

f3b2e2a

Fix

62ed325

Merge pull request #204 from plugwise/stick-mac-fw

91c9d1b

Collect Stick NodeInfo

Implement suggestion by digisaster

8036f85

Import sleep

3b493f9

bouwew requested a review from a team as a code owner February 16, 2025 12:56

Fix typo's

3dda79b

bouwew commented Feb 16, 2025

View reviewed changes

bouwew force-pushed the digisaster branch from 0cd1703 to 3dda79b Compare February 16, 2025 19:16

brefra reviewed Feb 28, 2025

View reviewed changes

bouwew force-pushed the async branch from 790a6a8 to 9fe1ed1 Compare April 18, 2025 09:00

bouwew closed this Apr 23, 2025

bouwew deleted the digisaster branch April 23, 2025 10:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implement suggestion from digisaster #206

Implement suggestion from digisaster #206

Uh oh!

bouwew commented Feb 16, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Feb 16, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codecov bot commented Feb 16, 2025 •

edited

Loading

Uh oh!

bouwew left a comment

Uh oh!

sonarqubecloud bot commented Feb 16, 2025

Uh oh!

bouwew commented Feb 27, 2025 •

edited

Loading

Uh oh!

brefra Feb 28, 2025

Uh oh!

bouwew commented Apr 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Implement suggestion from digisaster #206

Implement suggestion from digisaster #206

Uh oh!

Conversation

bouwew commented Feb 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Feb 16, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codecov bot commented Feb 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bouwew left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Feb 16, 2025

Quality Gate passed

Uh oh!

bouwew commented Feb 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brefra Feb 28, 2025

Choose a reason for hiding this comment

Uh oh!

bouwew commented Apr 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bouwew commented Feb 16, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Feb 16, 2025 •

edited

Loading

bouwew commented Feb 27, 2025 •

edited

Loading